[ENH] Additional prop tests for GC. #3883
Conversation
Properties checked - a) versions after cutoff are deleted b) versions before cutoff are preserved c) versions in version file are ordered d) min versions are retained
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
|
||
| proptest! { | ||
| #[test] | ||
| fn test_k8s_integration_gc_version_properties( |
There was a problem hiding this comment.
This should be reframed to not be a integration test. This logically can be tested entirely locally. This results in much faster prop test rollouts and then allows more cases to be tested.
| fn test_k8s_integration_gc_version_properties( | ||
| num_records in 50..100usize, | ||
| num_batches in 2..5usize, | ||
| cutoff_hours in 0..24i64, |
There was a problem hiding this comment.
This prop test is not really ideal. It randomly generates data and does a timing based approach. We should be use a state machine proptest - https://proptest-rs.github.io/proptest/proptest/state-machine.html. This will allow deterministic interleaving of the various events in the system.
There was a problem hiding this comment.
The prop test we need is one that is a state machine over GC at some resolution, that interleaves the various events in the system that GC is dependent on. Then we can have the proptest go over these and test the various sequences. Additionally, we should not have it as an integration test as we can then make it much faster and increase our ability to explore many cases.
Properties checked -
a) versions after cutoff are deleted
b) versions before cutoff are preserved
c) versions in version file are ordered
d) min versions are retained
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?